pfych/static
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

Naive element selection in web-component #19

New issue
Closed
opened 2025-09-15 23:47:39 +00:00 by pfych · 1 comment
pfych commented 2025-09-15 23:47:39 +00:00
Owner
Copy link

Lines 64 to 66 in d5e59e5
const elements = elementClassNames.map(
(className) => getElementsByClassName<HTMLDivElement>(className)?.[0],
);

This should be refactored to be scoped to the actual component itself (if this is possible with light-dom components)

https://git.pfy.ch/pfych/static/src/commit/d5e59e5701395aed350fde6f9f1844672711b267/content/custom/scripts/components/now-listening/nowListening.tsx#L64-L66 This should be refactored to be scoped to the actual component itself (if this is possible with light-dom components)
pfych commented 2025-10-31 05:35:51 +00:00
Author
Owner
Copy link

Fixed by passing the element references themselves!

Fixed by passing the element references themselves!
pfych closed this issue 2025-10-31 05:35:51 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
rewrite
No results found.
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
tests

Something requires tests

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
tests
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Personal Projects
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pfych/static#19
No description provided.